https://bugzilla.redhat.com/show_bug.cgi?id=2304086 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- Looks good to me. However I still stopped a few issues: 0. There is something wrong with the installation. See below what rpmlint says. Please remove unnecessary component (should be /usr/bin/glsl-analyzer instead of /usr/bin/glsl-analyzer/glsl_analyzer). 1. Please package LICENSE.md. Just add "%license LICENSE.md" to the %files section. This is a blocker. 2. Unless you plan to package it for some old RHEL versions consider using %autochangelog and %autorelease macros. Not a blocker - you may safely ignore that w/o explanation. We still don't have a consensus about whether it's good or bad. 3. Application seems to have a test-suite. Unless there is some issue(s) (internet access required, usage of proprietary or unpackaged components, etc) consider adding it in the future. Also not a blocker. 4. Rpmlint screams that "position-independent-executable-suggested" which sounds to me that glsl_analyzer isn't built with -fPIC or -fPIE. The application is better be built with these. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. See my note above. [x]: License field in the package spec file matches the actual license (GPLv3 exactly). [!]: License file installed when any subpackage combination is installed. See my note above. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: No development files. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contains systemd file. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not check if the package functions as described. [x]: Latest version is packaged (1.5.1). [x]: Package does not include license text files separate from upstream. [-]: Sources weren't verified with gpgverify since upstream does not publish signatures. [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. [-]: %check is not present. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: glsl-analyzer-1.5.1-1.fc41.x86_64.rpm glsl-analyzer-debuginfo-1.5.1-1.fc41.x86_64.rpm glsl-analyzer-debugsource-1.5.1-1.fc41.x86_64.rpm glsl-analyzer-1.5.1-1.fc41.src.rpm ========================================================================================================================================= rpmlint session starts ======================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpehrfdjy4')] checks: 32, packages: 4 glsl-analyzer.x86_64: E: subdir-in-bin /usr/bin/glsl-analyzer/glsl_analyzer ^^^^ This is a problem. See my note above . glsl-analyzer.x86_64: W: position-independent-executable-suggested /usr/bin/glsl-analyzer/glsl_analyzer ^^^^ This also sounds like a problem. See my note above. glsl-analyzer.x86_64: W: no-documentation =================================================================================================== 4 packages and 0 specfiles checked; 1 errors, 2 warnings, 20 filtered, 1 badness; has taken 1.3 s =================================================================================================== Rpmlint (debuginfo) ------------------- Checking: glsl-analyzer-debuginfo-1.5.1-1.fc41.x86_64.rpm ========================================================================================================================================= rpmlint session starts ======================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbhnzwixr')] checks: 32, packages: 1 ==================================================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.3 s =================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 glsl-analyzer.x86_64: W: unused-direct-shlib-dependency /usr/bin/glsl-analyzer/glsl_analyzer /lib64/libpthread.so.0 glsl-analyzer.x86_64: W: unused-direct-shlib-dependency /usr/bin/glsl-analyzer/glsl_analyzer /lib64/ld-linux-x86-64.so.2 glsl-analyzer.x86_64: E: subdir-in-bin /usr/bin/glsl-analyzer/glsl_analyzer glsl-analyzer.x86_64: W: position-independent-executable-suggested /usr/bin/glsl-analyzer/glsl_analyzer glsl-analyzer.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 16 filtered, 1 badness; has taken 0.9 s Source checksums ---------------- https://github.com/nolanderc/glsl_analyzer/archive/refs/tags/v1.5.1.tar.gz : CHECKSUM(SHA256) this package : e8505d71ff5be023766c951b7c540c65db6b0ec6815caecb845f4a79678740bf CHECKSUM(SHA256) upstream package : e8505d71ff5be023766c951b7c540c65db6b0ec6815caecb845f4a79678740bf Requires -------- glsl-analyzer (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libpthread.so.0()(64bit) glsl-analyzer-debuginfo (rpmlib, GLIBC filtered): glsl-analyzer-debugsource (rpmlib, GLIBC filtered): Provides -------- glsl-analyzer: glsl-analyzer glsl-analyzer(x86-64) glsl-analyzer-debuginfo: debuginfo(build-id) glsl-analyzer-debuginfo glsl-analyzer-debuginfo(x86-64) glsl-analyzer-debugsource: glsl-analyzer-debugsource glsl-analyzer-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2304086 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: SugarActivity, PHP, fonts, Ocaml, C/C++, Haskell, Perl, Java, Python, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Please fix/comment my notes above and we'll finish it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2304086 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202304086%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
