https://bugzilla.redhat.com/show_bug.cgi?id=2304086 --- Comment #3 from Marián Konček <mkoncek@xxxxxxxxxx> --- Thank you for looking into this. See this build: https://copr.fedorainfracloud.org/coprs/mkoncek/glsl-analyzer/build/7905794/ Addressed issues: 0: removed the directory part, the executable is now on path: /usr/bin/glsl_analyzer 1: added %license 2: I don't plan to ship it with older distributions, but i don't have experience with using these autofeatures, that's why i am not using them by default 3: added pytest dependencies and a %check phase, unfortunately the tests do not pass fully, reported upstream: https://github.com/nolanderc/glsl_analyzer/issues/37#issuecomment-2287102584 4: added a patch file that applies "fPIE", the result was verified with `file`: glsl_analyzer: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.0.0, BuildID[sha1]=99f53413187d1425015823ac0830d9461912d196, stripped For the tests I added another source. The upstream uses a git module referring to another repository of the same owner. I think this is a justified case of source bundling. I also asked upstream to provide a manpage, waiting for response. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2304086 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202304086%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
