https://bugzilla.redhat.com/show_bug.cgi?id=2301577 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. OK: fedora-review is confused by rpmautospec - There is no benefit to numbering the sole Source. You could replace Source0: %forgesource with Source: %forgesource (but no change is required). - You really do need to run the tests! There are very many tests that pass, and the failures seem to be real problems. You can begin by adding: # For tests: BuildRequires: %{py3_dist pytest} BuildRequires: %{py3_dist requests} and # Collecting these tests requires DNS: ignore="${ignore-} --ignore=upath/tests/implementations/test_http.py" # These tests require Internet access: ignore="${ignore-} --ignore=upath/tests/implementations/test_github.py" %pytest ${ignore-} This results in one failing test on F40, plus some avoidable skipped tests that we can revisit. =================================== FAILURES =================================== _______________________________ test_uri_parsing _______________________________ def test_uri_parsing(): > assert ( str(UPath("http://www.example.com//a//b/";)) == "http://www.example.com//a//b/"; ) E AssertionError: assert 'http://www.e....com////a//b/' == 'http://www.e...le.com//a//b/' E - http://www.example.com//a//b/ E + http://www.example.com////a//b/ E ? ++ upath/tests/test_core.py:325: AssertionError This is fixed by adding: # upath._flavour: fix path parsing due to change in urllib.parse.SplitResult # behavior # https://github.com/fsspec/universal_pathlib/commit/07a458375c6c4c722bf1e6c0fab2bc303901b65b Patch: %{forgeurl}/commit/07a458375c6c4c722bf1e6c0fab2bc303901b65b.patch and passing -p1 to %forgeautosetup. By adding the following, you can get some additional passing tests (on F40) and no new failures: # For additional optional tests: BuildRequires: %{py3_dist cheroot} BuildRequires: %{py3_dist gcsfs} BuildRequires: %{py3_dist pydantic} BuildRequires: %{py3_dist wsgidav} # Required for tests that use pydantic: BuildRequires: %{py3_dist pydantic-settings} # Required for tests that use wsgidav: BuildRequires: %{py3_dist webdav4} # For additional optional tests, but not packaged: %dnl BuildRequires: %{py3_dist moto} %dnl BuildRequires: %{py3_dist s3fs} All of the above is the “good news!” The bad news is that since we started with all enabled tests passing in F40, all of the following problems in F41/Rawhide must be regressions from Python 3.13 or from dependency updates: FAILED upath/tests/test_core.py::TestUpath::test_iterdir - AttributeError: 's... FAILED upath/tests/test_core.py::TestUpath::test_iterdir2 - AttributeError: '... FAILED upath/tests/test_core.py::TestUpath::test_iterdir_trailing_slash - Att... FAILED upath/tests/test_core.py::TestUpath::test_rmdir_not_empty - AttributeE... FAILED upath/tests/test_core.py::TestUpath::test_access_to_private_api - Attr... FAILED upath/tests/test_core.py::test_normalize[http://example.com/a/../..//-http://example.com//] FAILED upath/tests/test_core.py::test_normalize[http://example.com/a/..//-http://example.com//] FAILED upath/tests/test_core.py::test_normalize[http://example.com/a/..//.-http://example.com//] FAILED upath/tests/test_core.py::test_normalize[http://example.com/a/..//b-http://example.com//b] FAILED upath/tests/test_core.py::test_normalize[http://example.com/a//../..//-http://example.com//] FAILED upath/tests/test_core.py::test_normalize[http://example.com/a//..//-http://example.com/a//] FAILED upath/tests/test_core.py::test_normalize[http://example.com/a//..//.-http://example.com/a//] FAILED upath/tests/test_core.py::test_normalize[http://example.com/a//..//b-http://example.com/a//b] FAILED upath/tests/implementations/test_data.py::TestUPathDataPath::test_access_to_private_api FAILED upath/tests/implementations/test_local.py::TestFSSpecLocal::test_iterdir FAILED upath/tests/implementations/test_local.py::TestFSSpecLocal::test_iterdir2 FAILED upath/tests/implementations/test_local.py::TestFSSpecLocal::test_iterdir_trailing_slash FAILED upath/tests/implementations/test_local.py::TestFSSpecLocal::test_rmdir_not_empty FAILED upath/tests/implementations/test_local.py::TestFSSpecLocal::test_access_to_private_api FAILED upath/tests/implementations/test_local.py::TestRayIOFSSpecLocal::test_iterdir FAILED upath/tests/implementations/test_local.py::TestRayIOFSSpecLocal::test_iterdir2 FAILED upath/tests/implementations/test_local.py::TestRayIOFSSpecLocal::test_iterdir_trailing_slash FAILED upath/tests/implementations/test_local.py::TestRayIOFSSpecLocal::test_rmdir_not_empty FAILED upath/tests/implementations/test_local.py::TestRayIOFSSpecLocal::test_access_to_private_api FAILED upath/tests/implementations/test_memory.py::TestMemoryPath::test_iterdir FAILED upath/tests/implementations/test_memory.py::TestMemoryPath::test_iterdir2 FAILED upath/tests/implementations/test_memory.py::TestMemoryPath::test_iterdir_trailing_slash FAILED upath/tests/implementations/test_memory.py::TestMemoryPath::test_rmdir_not_empty FAILED upath/tests/implementations/test_memory.py::TestMemoryPath::test_access_to_private_api FAILED upath/tests/implementations/test_webdav.py::TestUPathWebdav::test_iterdir FAILED upath/tests/implementations/test_webdav.py::TestUPathWebdav::test_iterdir2 FAILED upath/tests/implementations/test_webdav.py::TestUPathWebdav::test_iterdir_trailing_slash FAILED upath/tests/implementations/test_webdav.py::TestUPathWebdav::test_rmdir_not_empty FAILED upath/tests/implementations/test_webdav.py::TestUPathWebdav::test_access_to_private_api = 34 failed, 527 passed, 272 skipped, 77 deselected, 2 xfailed, 10 warnings in 2.54s = I reported these upstream in https://github.com/fsspec/universal_pathlib/issues/245, in addition to the pre-existing issue https://github.com/fsspec/universal_pathlib/issues/221 for testing with Python 3.13, but I don’t understand this code well enough to fix it without a lot of research, so my best suggestion (as ugly as it is) is the following: %if v"0%{?python3_version}" >= v"3.13" # Test regressions with Python 3.13 # https://github.com/fsspec/universal_pathlib/issues/245 k="${k-}${k+ and }not (TestFSSpecLocal and test_access_to_private_api)" k="${k-}${k+ and }not (TestFSSpecLocal and test_iterdir)" k="${k-}${k+ and }not (TestFSSpecLocal and test_iterdir2)" k="${k-}${k+ and }not (TestFSSpecLocal and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestFSSpecLocal and test_rmdir_not_empty)" k="${k-}${k+ and }not (TestMemoryPath and test_access_to_private_api)" k="${k-}${k+ and }not (TestMemoryPath and test_iterdir)" k="${k-}${k+ and }not (TestMemoryPath and test_iterdir2)" k="${k-}${k+ and }not (TestMemoryPath and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestMemoryPath and test_rmdir_not_empty)" k="${k-}${k+ and }not (TestRayIOFSSpecLocal and test_access_to_private_api)" k="${k-}${k+ and }not (TestRayIOFSSpecLocal and test_iterdir)" k="${k-}${k+ and }not (TestRayIOFSSpecLocal and test_iterdir2)" k="${k-}${k+ and }not (TestRayIOFSSpecLocal and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestRayIOFSSpecLocal and test_rmdir_not_empty)" k="${k-}${k+ and }not (TestUPathDataPath and test_access_to_private_api)" k="${k-}${k+ and }not (TestUPathGitHubPath and test_access_to_private_api)" k="${k-}${k+ and }not (TestUPathGitHubPath and test_iterdir)" k="${k-}${k+ and }not (TestUPathGitHubPath and test_iterdir2)" k="${k-}${k+ and }not (TestUPathGitHubPath and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestUPathGitHubPath and test_rmdir_not_empty)" k="${k-}${k+ and }not (TestUPathHttp and test_access_to_private_api)" k="${k-}${k+ and }not (TestUPathHttp and test_is_dir)" k="${k-}${k+ and }not (TestUPathHttp and test_is_file)" k="${k-}${k+ and }not (TestUPathHttp and test_iterdir)" k="${k-}${k+ and }not (TestUPathHttp and test_iterdir2)" k="${k-}${k+ and }not (TestUPathHttp and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestUPathHttp and test_rmdir_not_empty)" k="${k-}${k+ and }not (TestUPathHttp and test_work_at_root)" k="${k-}${k+ and }not (TestUPathS3 and test_access_to_private_api)" k="${k-}${k+ and }not (TestUPathS3 and test_iterdir)" k="${k-}${k+ and }not (TestUPathS3 and test_iterdir2)" k="${k-}${k+ and }not (TestUPathS3 and test_iterdir_root)" k="${k-}${k+ and }not (TestUPathS3 and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestUPathS3 and test_iterdir_with_plus_in_name)" k="${k-}${k+ and }not (TestUPathS3 and test_rmdir_not_empty)" k="${k-}${k+ and }not (TestUPathWebdav and test_access_to_private_api)" k="${k-}${k+ and }not (TestUPathWebdav and test_iterdir)" k="${k-}${k+ and }not (TestUPathWebdav and test_iterdir2)" k="${k-}${k+ and }not (TestUPathWebdav and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestUPathWebdav and test_rmdir_not_empty)" k="${k-}${k+ and }not (TestUpath and test_access_to_private_api)" k="${k-}${k+ and }not (TestUpath and test_iterdir)" k="${k-}${k+ and }not (TestUpath and test_iterdir2)" k="${k-}${k+ and }not (TestUpath and test_iterdir_trailing_slash)" k="${k-}${k+ and }not (TestUpath and test_rmdir_not_empty)" k="${k-}${k+ and }not test_normalize" %endif %pytest ${ignore-} -k "${k-}" While this is messy, and it is likely that the skipped tests reflect real problems that may affect dependent packages, it is still better than not running any tests. For example, this configuration still would have caught the regression in test_uri_parsing that we patched. Hopefully upstream will catch up soon, and these skips can be removed. - The file upath/_compat.py contains code vendored/copied from CPython; see https://github.com/python/cpython/blob/v3.12.2/Lib/pathlib.py. We should change License: MIT to # The entire source is MIT, except that upath/_compat.py contains code from # CPython (see https://github.com/python/cpython/blob/v3.12.2/Lib/pathlib.py), # which is Python-2.0.1. License: MIT AND Python-2.0.1 add add (in the python3-universal-pathlib subpackage): # Parts of upath/_compat.py are copied from CPython 3.12. Since the relevant # work began on 2024-02-20 in # https://github.com/fsspec/universal_pathlib/pull/200 and was merged in # https://github.com/fsspec/universal_pathlib/pull/200 on 2024-03-03, we # ascribe the code to the latest 3.12 release at the time. Provides: bundled(python3-libs) = 3.12.2 - It would be helpful to ship CHANGELOG.md as documentation alongside README.md. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* curl License". 57 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2301577-python-universal- pathlib/licensecheck.txt Code bundled from python3-libs is actually Python-2.0.1. See Issues. [x]: License file installed when any subpackage combination is installed. [!]: Package contains no bundled libraries without FPC exception. Bundled code from python3-libs should be handled as described in Issues. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 23441 bytes in 1 files. [x]: Package complies to the Packaging Guidelines (except as noted) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Messages are bogus (spelling non-errors) [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-universal-pathlib [x]: Package functions as described. There are probably some functional issues on Python 3.13; however, reporting them upstream is probably the best we can do for now, and the package is at least partially functional (and fine on Python 3.12). [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. As noted in Issues, I think the import-only smoke test is insufficient for this package. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: differences are only due to rpmautospec macro expansions. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-universal-pathlib-0.2.2-4.fc41.noarch.rpm python-universal-pathlib-doc-0.2.2-4.fc41.noarch.rpm python-universal-pathlib-0.2.2-4.fc41.src.rpm ============================================================================================ rpmlint session starts ============================================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxnwx99pr')] checks: 32, packages: 3 python-universal-pathlib.src: E: spelling-error ('api', 'Summary(en_US) api -> API, pi, ape') python-universal-pathlib.src: E: spelling-error ('fsspec', 'Summary(en_US) fsspec -> spec') python3-universal-pathlib.noarch: E: spelling-error ('api', 'Summary(en_US) api -> API, pi, ape') python3-universal-pathlib.noarch: E: spelling-error ('fsspec', 'Summary(en_US) fsspec -> spec') ====================================================== 3 packages and 0 specfiles checked; 4 errors, 0 warnings, 20 filtered, 4 badness; has taken 0.5 s ======================================================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-universal-pathlib.noarch: E: spelling-error ('api', 'Summary(en_US) api -> API, pi, ape') python3-universal-pathlib.noarch: E: spelling-error ('fsspec', 'Summary(en_US) fsspec -> spec') 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 12 filtered, 2 badness; has taken 0.2 s Source checksums ---------------- https://github.com/fsspec/universal_pathlib/archive/v0.2.2/universal_pathlib-0.2.2.tar.gz : CHECKSUM(SHA256) this package : 0bca90aaf72075609f6352a6680865c59bf8099e0b2006a7082a0402bc403256 CHECKSUM(SHA256) upstream package : 0bca90aaf72075609f6352a6680865c59bf8099e0b2006a7082a0402bc403256 Requires -------- python3-universal-pathlib (rpmlib, GLIBC filtered): python(abi) python3.13dist(fsspec) python-universal-pathlib-doc (rpmlib, GLIBC filtered): Provides -------- python3-universal-pathlib: python-universal-pathlib python3-universal-pathlib python3.13-universal-pathlib python3.13dist(universal-pathlib) python3dist(universal-pathlib) python-universal-pathlib-doc: python-universal-pathlib-doc Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2301577-python-universal-pathlib/srpm/python-universal-pathlib.spec 2024-07-30 07:58:26.319497614 -0400 +++ /home/ben/fedora/review/2301577-python-universal-pathlib/srpm-unpacked/python-universal-pathlib.spec 2024-07-29 20:00:00.000000000 -0400 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 4; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global forgeurl https://github.com/fsspec/universal_pathlib @@ -72,3 +82,15 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Tue Jul 30 2024 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> - 0.2.2-4 +- fix: include license in doc subpackage + +* Tue Jul 30 2024 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> - 0.2.2-3 +- fix: remove duplicated license + +* Tue Jul 30 2024 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> - 0.2.2-2 +- feat: ready for review + +* Tue Jul 30 2024 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> - 0.2.2-1 +- chore: init +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2301577 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Ocaml, C/C++, R, Haskell, Perl, fonts, Java, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2301577 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202301577%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
