https://bugzilla.redhat.com/show_bug.cgi?id=2295820 --- Comment #24 from Tim Flink <tflink@xxxxxxxxxx> --- (In reply to Tom Rix from comment #23) > (In reply to Tim Flink from comment #19) > > Created attachment 2041182 [details] > > specfile changes for discussion > > > > I've attached an initial patch for the hipblaslt specfile that contains a > > few things, three are pretty minor: > > > > 1. I changed a few of the BuildRequires to use pkgconfig where appropriate > Can you explain (likely again) why pkgconfig ? I would prefer to keep the > BuildRequires as-is unless there is a MUST item somewhere you can point to. It's a SHOULD according to the packaging guidelines. I understand why its a thing but I don't personally have any strong feelings about it. https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ > > 2. I added a different way to disable the rpath check disable when building > > --with test that works with mock. I'd like to have this in all of the rocm > > packages that have -test subpackages to make building them easier but this > > can wait for a more general discussion, it doesn't have to be added now if > > there are objections. > > Having a mockable set of -test subpackages is generally good, then we can > talk about getting them into the distro. Did you want to do this for the > set ? Beyond getting the -test packages into the distro, it makes them easier to build in copr and makes them easier to build for me personally since I almost always use mock for local package builds. Like I said, I don't care a ton if it's done right now. It's something that I'm definitely going to be proposing for all the ROCm packages once I'm able to to spend more time testing them - the builtin packages seem to be the best place to start. > > 3. I added some missing deps from the -test subpackage > > > > I'll add these if there is another revision, but these would fall out of #2 > if you wanted to do #2. I don't understand what those deps have to do with making -test buildable in mock. The current package doesn't build --with test even if %global __brp_check_rpaths %{nil} is used instead of QA_RPATHS=0xff. The build deps I added fix that build problem. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2295820 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295820%23c24 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
