https://bugzilla.redhat.com/show_bug.cgi?id=2295820 --- Comment #23 from Tom Rix <trix@xxxxxxxxxx> --- (In reply to Tim Flink from comment #19) > Created attachment 2041182 [details] > specfile changes for discussion > > I've attached an initial patch for the hipblaslt specfile that contains a > few things, three are pretty minor: > > 1. I changed a few of the BuildRequires to use pkgconfig where appropriate Can you explain (likely again) why pkgconfig ? I would prefer to keep the BuildRequires as-is unless there is a MUST item somewhere you can point to. > 2. I added a different way to disable the rpath check disable when building > --with test that works with mock. I'd like to have this in all of the rocm > packages that have -test subpackages to make building them easier but this > can wait for a more general discussion, it doesn't have to be added now if > there are objections. Having a mockable set of -test subpackages is generally good, then we can talk about getting them into the distro. Did you want to do this for the set ? > 3. I added some missing deps from the -test subpackage > I'll add these if there is another revision, but these would fall out of #2 if you wanted to do #2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2295820 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295820%23c23 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
