https://bugzilla.redhat.com/show_bug.cgi?id=2297307 --- Comment #3 from Cristian Le <fedora@xxxxxxxxx> --- > 2. What I am not sure about is the contents of src/langs/*.txt. I tried to do some digging, and it seems that some other "bip" have license, but there is no license described for bip39, probably because it is still as proposal. From what I saw, the licensing details is described here [1]. They don't have issues or good PR discussions to ask for clarification. From the usage, it seems to be a well defined list to map byte sequence to mnemonic words, so it should be copyrightable. I tried to look at the discussion on python-mnemonic, but the licensing issue of bip-0039 was never raised. The only other place to raise the issue would be in bitcoindev@xxxxxxxxxxxxxxxx, and I cannot contact them without spoofing my gmail account and opening myself to a barrage of uncontrolled spams. Any suggestions on what to do on that front? > 1. This crate contains test data from https://github.com/trezor/python-mnemonic which is MIT licensed. Roger, I don't see a mechanism in `rust2rpm.toml` so I guess I would do it manually. This package has barely any activity so probably would not need to worry that much (hopefully they will converge and figure themselves out [2] before we have a similar situation to the unicode packages) > 3. The summary of the crate is quite meaningless Well there are a bunch of crates that implement BIP-0039, would it be ok if the `Summary` clash between them? I am considering the `Summary` to be just "Rust implementation of BIP-0039", and append the bip abstract ti it: ``` A fork of the bip39 crate with fixes to v0.6. Rust implementation ofBIP-0039. This BIP describes the implementation of a mnemonic code or mnemonic sentence -- a group of easy to remember words -- for the generation of deterministic wallets. It consists of two parts: generating the mnenomic, and converting it into a binary seed. This seed can be later used to generate deterministic wallets using BIP-0032 or similar methods. ``` wdyt? Probably getting rid of the last sentence of the abstract. [1]: https://github.com/bitcoin/bips/blob/master/bip-0002.mediawiki#bip-licensing [2]: https://crates.io/keywords/mnemonic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2297307 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297307%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
