https://bugzilla.redhat.com/show_bug.cgi?id=2297307 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Three things that will need to be addressed in some way: 1. This crate contains test data from https://github.com/trezor/python-mnemonic which is MIT licensed. Since it's only in test code I don't think it should affect the license of the package, but it might be a good idea to %exclude tests/standard-vectors.rs from the -devel file so no MIT-only licensed content is included in the package. 2. What I am not sure about is the contents of src/langs/*.txt. I don't really understand what this crate does or is (see 3.), but are the lists of words somehow meaningful, relevant or copyrightable? Or are they just "list of words in different languages that make good mnemonics"? 3. The summary of the crate is quite meaningless. The generated one ("Fork of the bip39 crate with fixes to v0.6") is even worse than the original one ("Rust implementation of BIP-0039"), not neither of them mean anything if you don't know what BIP-0039 is. Maybe this can be improved somehow? The Python package from where the test vecors are taken uses "Mnemonic code for generating deterministic keys, BIP39" as description, that seems to be better IMO. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2297307 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297307%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
