https://bugzilla.redhat.com/show_bug.cgi?id=2297640 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Peter Lemenkov from comment #2) > Done. > > Done. Thanks! > I'd keep it as is. Some of my packages' spec-0files are almost verbatic > copies, so I'd keep more macros instead of values. I hope one day we'll use > even less boilerplate using more complex macros. OK! > Done. Thanks, nice trick! 👍 > Honestly there is not much to make man-page of it. This package is intended > as a library with a very tiny shell-script to encode/decode so I'd keep it > w/o man-page for now. The guidelines say SHOULD, not MUST, so that’s your choice to make. > New package, the same links: > > Spec URL: https://peter.fedorapeople.org/packages/python-base58.spec > SRPM URL: > https://peter.fedorapeople.org/packages/python-base58-2.1.1-1.fc40.src.rpm Thanks! I’ll go ahead and start reviewing this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2297640 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297640%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
