https://bugzilla.redhat.com/show_bug.cgi?id=2299173 --- Comment #7 from Sandro Bonazzola <sbonazzo@xxxxxxxxxx> --- (In reply to Dorinda from comment #6) > There's a warning about `warning: rust-virtio-vsock-0.6.0-1.fc41.src.rpm: > Header V4 RSA/SHA256 Signature, key ID b6048b48: NOKEY` This is the COPR repo GPG key being used. > also i think it may be better to use the doc macro in the license part > ``` > # dealing with missing license files in the crate > %license docs/LICENSE-APACHE > %license docs/LICENSE-BSD-3-Clause > ``` > other than that LGTM. license files are required to be added using license macro to ensure they get installed even when the rpm is installed with `dnf install --nodocs` to comply with legal requirements. It also allow to see them when querying the rpm with `rpm -q --licensefiles`. More details at https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2299173 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299173%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
