https://bugzilla.redhat.com/show_bug.cgi?id=2297640 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Ben Beasley from comment #1) > ===== Issues ===== > > - The zero-argument form of %{pypi_source} is deprecated. Done. > - The description must be wrapped to 80 characters. > - Since the %{pyproject_files} contain a properly-marked license file, you > don’t need to package a duplicate in %{_licensedir}. Done. > ===== Notes (no change required for approval) ===== > > - I personally think that using the %{pypi_name} macro does not meaningfully > improve spec-file “reusability,” and just makes the spec harder to read by > adding a level of macro indirection. I favor replacing it with the actual > name (in this case, base58) everywhere it appears. However, there is > nothing > *objectively* wrong with using the macro, and it’s absolutely permissible. > > - It is not necessary or useful to number the sole Source. It would be better > to just write > > Source: %{pypi_source base58} > > but again, the numbered Source0 form is not prohibited. I'd keep it as is. Some of my packages' spec-0files are almost verbatic copies, so I'd keep more macros instead of values. I hope one day we'll use even less boilerplate using more complex macros. > - You can avoid repeating the description text by using a macro, e.g.: > > %global common_description %{expand: > Base58 and Base58Check implementation compatible with what is used by the > bitcoin network.} > > %description %{common_description} > > […] > > %description -n python3-base58 %{common_description} Done. Thanks, nice trick! > - A man page is always desirable for a command-line tool. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages > > This was mentioned by rpmlint: > > python3-base58.noarch: W: no-manual-page-for-binary base58 > > In this case, help2man generates an acceptable man page. You could add > > BuildRequires: help2man > > then, in %install: > > # Generate the man page in %%install rather than %%build because we need > the > # generated script entry point. > PYTHONPATH='%{buildroot}%{python3_sitelib}' \ > PATH="${PATH}:%{buildroot}%{_bindir}" \ > help2man --no-info --output='%{buildroot}%{_mandir}/man1/base58.1' \ > --version-string='%{version}' --name='%{summary}' base58 > > and finally, in %files -n python3-base58, > > %{_mandir}/man1/base58.1* > > This is not required for approval, but it is a SHOULD in the guidelines, > and > I think you should use help2man here since it does an adequate job. Honestly there is not much to make man-page of it. This package is intended as a library with a very tiny shell-script to encode/decode so I'd keep it w/o man-page for now. New package, the same links: Spec URL: https://peter.fedorapeople.org/packages/python-base58.spec SRPM URL: https://peter.fedorapeople.org/packages/python-base58-2.1.1-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2297640 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297640%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
