Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 ------- Additional Comments From mnagy@xxxxxxxxxx 2008-01-25 08:34 EST ------- (In reply to comment #25) I have made yet another srpm: http://people.redhat.com/mnagy/lftp-3.6.1-1.fc9.src.rpm > I think that the DEBUG stuff should be removed. I see no reason for it to be there, so done. > The > LDFLAGS="-L`pwd`/src/.libs $LDFLAGS"; > certainly needs an explanation. I tried without and it built fine. This is a bit odd, it's been there for a longer time than it is in CVS, so no idea who put it there. Anyway, I removed it and it built fine for me too. > Also why use the system libtool? Is it to avoid the rpath? If it > doesn't work is it useful to keep it? And also is it really > useful to use system libtool for the install? Hmm, good idea, I'll ask the previous maintainer if he remembers (this was done 6 years ago) why are we using system libtool. I fixed this in srpm. > I also suggest doing > iconv -f ISO88591 -t UTF8 NEWS -o NEWS.tmp > touch -r NEWS NEWS.tmp > mv -f NEWS.tmp NEWS > to keep the NEWS file timestamp. My fault, sorry about that, fixed. > The postun is wrong, it should be run each time. Fixed as well. I also changed the patch which is better now. Patrice: Thanks for spotting these. Ruben: I still haven't commited the changes into cvs, could you please review if these changes are good? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review