Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 ------- Additional Comments From pertusus@xxxxxxx 2008-01-24 17:08 EST ------- Are you sure that files in %{_libdir}/lftp/%{version}/ are not dlopened and that /etc/ld.so.conf.d/%{name}-%{_arch}.conf is useful? I think that the DEBUG stuff should be removed. The LDFLAGS="-L`pwd`/src/.libs $LDFLAGS"; certainly needs an explanation. I tried without and it built fine. Also why use the system libtool? Is it to avoid the rpath? If it doesn't work is it useful to keep it? And also is it really useful to use system libtool for the install? I also suggest doing iconv -f ISO88591 -t UTF8 NEWS -o NEWS.tmp touch -r NEWS NEWS.tmp mv -f NEWS.tmp NEWS to keep the NEWS file timestamp. The postun is wrong, it should be run each time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review