Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: nspr https://bugzilla.redhat.com/show_bug.cgi?id=226202 limb@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From limb@xxxxxxxxxxxx 2008-01-25 08:59 EST ------- rpmlint on SRPM: Unversion obsoletes for mozilla-nspr and mozilla-nspr-devel. Probably want to correct this. nspr.src: E: no-cleaning-of-buildroot %install You should clean $RPM_BUILD_ROOT in the %clean section and just after the beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT". MUST fix this. nspr.src: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Cosmetic, but since you're making changes anyway. . . There are no documentation files in either the main package or -devel. If there are none, this is OK, which seems to be the case. The Source0 tag lacks a URL, and I can't locate the appropriate tarball on the upstream site, so I can't compare the upstream tarball and SRPM tarball. If this a modifed upstream tarball or cvs snapshot, please include a script that creates this tarball from upstream. Otherwise, it looks pretty good, no other blockers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review