https://bugzilla.redhat.com/show_bug.cgi?id=2272354 --- Comment #2 from Peter Robinson <pbrobinson@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > 1. unaddressed FIXME: > > > # FIXME: no license files detected > > This needs to be addressed in one way or another, I see you already filed an > issue - thanks! > https://github.com/qnighy/yasna.rs/issues/76 > > Ideally, upstream should be asked to include "LICENSE-*" files here: > https://github.com/qnighy/yasna.rs/blob/master/Cargo.toml#L14-L17 > > And publish new versions. Can you submit a PR for this? It's on my backlog but I don't see upstream fix should block it, yes I'll update locally to add the LICENSE file. > Until that is fixed upstream, you will need to include the license files from > https://github.com/qnighy/yasna.rs manually as separate source files. > > 2. Why do tests fail on 32-bit x86? Is this a real problem in the code or > problems with the tests? TBH I don't have time to look into it and I don't personally care about 32 bit > Not sure if this addresses *all* failures on i686, but it would be great if > that commit could be included as a patch and the tests enabled > unconditionally. I would generally just err on disabling 32 bit in general, can you explain why it matters? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2272354 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202272354%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
