https://bugzilla.redhat.com/show_bug.cgi?id=2272354 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- 1. unaddressed FIXME: > # FIXME: no license files detected This needs to be addressed in one way or another, I see you already filed an issue - thanks! https://github.com/qnighy/yasna.rs/issues/76 Ideally, upstream should be asked to include "LICENSE-*" files here: https://github.com/qnighy/yasna.rs/blob/master/Cargo.toml#L14-L17 And publish new versions. Can you submit a PR for this? Until that is fixed upstream, you will need to include the license files from https://github.com/qnighy/yasna.rs manually as separate source files. 2. Why do tests fail on 32-bit x86? Is this a real problem in the code or problems with the tests? It looks like the Debian packagers also found this problem and submitted a PR to fix something: https://github.com/qnighy/yasna.rs/pull/73 Not sure if this addresses *all* failures on i686, but it would be great if that commit could be included as a patch and the tests enabled unconditionally. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2272354 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202272354%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
