https://bugzilla.redhat.com/show_bug.cgi?id=2263654 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |carl@xxxxxxxxxx Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value CC| |carl@xxxxxxxxxx --- Comment #2 from Carl George 🤠 <carl@xxxxxxxxxx> --- Taking this review. On an initial pass, I noticed that version 1.0.6 is tagged upstream and uploaded to PyPI, which includes several fixes relevant to this package. - the LICENSE file is included - the README.md file is no longer executable - the README.md file no longer has the wrong end of line encoding Updating to that version should allow you to drop several things from the spec file that are no longer necessary. https://github.com/apmorton/pyhidapi/releases/tag/1.0.6 Calling %{pypi_source} without an argument is deprecated, so that should be changed to %{pypi_source %{srcname}}. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pypi_source The %license line can be dropped from the %files section, because the LICENSE file is including in the dist-info directory and is properly marked as a license. You can future proof this by adding the -l flag to %pyproject_save_files. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_save_files Build requiring hidapi-devel seems incorrect. This is a noarch package that doesn't link against the hidapi library. In the source code this loops through a list of library file names to load with ctypes.cdll. The first one on the list (libhidapi-hidraw.so) is indeed in hidapi-devel, but the second one on the list (libhidapi-hidraw.so.0) is in hidapi, so we can get away with just build requiring hidapi, not hidapi-devel. Since our %check is just an import check, the build requirements shouldn't be any different from the runtime requirements (other than python3-devel of course). https://github.com/apmorton/pyhidapi/blob/1.0.6/hid/__init__.py#L9-L31 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2263654 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263654%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
