https://bugzilla.redhat.com/show_bug.cgi?id=2270856 Matthieu Saulnier <casper@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Matthieu Saulnier <casper@xxxxxxxxxxxxxxxxxx> --- I see 4 issues in the package: [!]: Package consistently uses macros (instead of hard-coded directory names). See below: - The Name: tag is not using %{pkgname} macro (like in your other package) - in %%install section: src/fplsa4.ini - in %%files section, macro again: %{pkgname}4.ini Also, the doc package seems to be empty, this is an explanation why: you are creating the doc directory with the %{upname} macro, but the scriptlet "%gap_copy_docs" is not using the same path. the scriptlet is printing its own path during the build: /builddir/build/BUILDROOT/gap-pkg-fplsa-1.2.6-1.fc40.x86_64/usr/lib64/gap/pkg/fplsa/doc (see, there is no upper case in the path) the result is: the directory %{gap_archdir}/pkg/%{upname}/doc is correctly packaged, but it is empty, AND there is no rpmbuild warning about the unpackaged files remaining in the buildroot directory (don't know why). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2270856 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270856%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
