https://bugzilla.redhat.com/show_bug.cgi?id=2271976 --- Comment #8 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Version: %{ver}~%{date} This does not contain the snapshot version data expected. e.g. something like "Version: %{ver}~git%{date}.%{sub %{commit} 1 7}" to ensure full snapshot versioning is present. > Source: cosmic-comp-%{ver}.tar.xz > Source: cosmic-comp-%{ver}-vendor.tar.xz This should probably be versioned with %{commit} instead. Also, please add notes/scripts for how the tarballs are generated as comments or additional sources so it's captured in the SRPM. > # %%license cargo-vendor.txt Why is this commented out? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2271976 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202271976%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
