https://bugzilla.redhat.com/show_bug.cgi?id=2270856 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Matthieu. (In reply to Matthieu Saulnier from comment #2) > I see 4 issues in the package: > > [!]: Package consistently uses macros (instead of hard-coded directory > names). See below: > > - The Name: tag is not using %{pkgname} macro (like in your other package) That isn't what "consistently uses macros" means. As the parenthetical remark indicates, it's talking about using %{_bindir} instead of "/usr/bin", %{_libdir} instead of "/usr/lib" or "/usr/lib64", etc. Nevertheless, you are correct that I have written "Name: gap-pkg-%{pkgname}" in other gap spec files, so I should be consistent with myself. :-) Fixed. > - in %%install section: src/fplsa4.ini > > - in %%files section, macro again: %{pkgname}4.ini Hmmm, %files has "%config(noreplace) %{_sysconfdir}/fplsa4.ini" in my copy. Did I upload a version that has "%{pkgname}4.ini"? In any case, the version I just uploaded consistently uses the name "fplsa4.ini" everywhere. > Also, the doc package seems to be empty, this is an explanation why: Oops! Yes, %gap_copy_docs needs a -n argument. Fixed. The new spec and source rpm files are at the same URLs as above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2270856 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270856%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
