https://bugzilla.redhat.com/show_bug.cgi?id=2268679 --- Comment #6 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to José Matos from comment #5) > Hi Sandro, > is there a reason to be using the development version and not the stable > release? I anticipated version 0.2.0 is going to be released soon since the tag was present already. Upstream confirmed that [1] in the discussion regarding my PR (#39), which evolved into PR #40, which is the patch applied. > Is that due to the test issue that you identified above. > > Because that is only reason where fedora-review rightly complains: > - Sources used to build the package match the upstream source, as provided > in the spec URL. I'm not seeing any complaint. For rawhide and F40 there's no template generated. Looking at the F38 template [2] I see: [x]: Sources used to build the package match the upstream source, as provided in the spec URL. That's a pass. I guess you ran fedora-review after review service. > The difference is related with changes introduced upstream, while your > original package used a previous commit. > The patch is not applied because it is already applied upstream. I guess upstream may have moved the tag. Very naughty, but permissible, I suppose, since it wasn't officially released. They mentioned releasing after PR #40 was merged. > Other than that this is a simple python package. The licenses are correct > and admissible on Fedora and the package follows the Fedora package > guidelines for Python packages. > > Please fix the source issue on import. I'll do that. Spec URL: https://gui1ty.fedorapeople.org/review/python-cmap.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-cmap-0.2.0-3.fc41.src.rpm [1] https://github.com/tlambert03/cmap/pull/39#discussion_r1518611308 [2] https://download.copr.fedorainfracloud.org/results/%40fedora-review/fedora-review-2268679-python-cmap/fedora-38-x86_64/07129688-python-cmap/fedora-review/review.txt -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2268679 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202268679%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
