https://bugzilla.redhat.com/show_bug.cgi?id=2260080 --- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> --- Okay, this looks pretty good. I think two more changes are needed. First, SPDX uses upper-case connectives, so change "and" to "AND" in the examples package License field. (https://docs.fedoraproject.org/en-US/legal/spdx/#_and_expressions) Second, the version number is 0^21012024.4847dea7. The "21012024" part looks like a date: 21 Jan 2024. In that case, the order should be year-month-day, not day-month-year. The reason is that it won't sort properly in this order. Consider: 21 Jan 2024 = 21012024 13 Feb 2024 = 13022024 but 13022024 < 21012024. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2260080 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260080%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
