https://bugzilla.redhat.com/show_bug.cgi?id=2260080 --- Comment #5 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- - Is there a point in installing non-Linux platform files in %{_datadir}/lqml/platforms (android, ios, etc.)? The same question goes for the readme files for those platforms, and for non-Linux platform files in the examples. Android is helpful since one can also install the NDK and SDK to generate apk files. Unclear about the others, want to stay close to upstream. - The file examples/wear-os-heart/qt-sensor-hack/QtActivity.java is included in the examples subpackage. It carries a BSD-2-Clause license. Add that to the License field for the examples subpackage. Done. Thanks. - The spec file mentions removing examples with font files, but there is still one: examples/advanced-qml-auto-reload/qml, which has TTF files in a fonts subdirectory. Modified this to use fonts that are packaged in Fedora. - See the EXTRA item below: "Large data in /usr/share should live in a noarch subpackage if package is arched." Should the examples package be noarch? Made it noarch. Thanks. - Note the hidden-file-or-dir rpmlint warnings. Are those files necessary? Removed them. - Note the files-duplicate rpmlint warnings. Is there some way to avoid the duplication? Can softlink, though they are for the examples which is a separate package. Seems better to stay close to upstream, but suggestions for other packaging options are welcome. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260080 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260080%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
