https://bugzilla.redhat.com/show_bug.cgi?id=2261201 --- Comment #4 from Tim Flink <tflink@xxxxxxxxxx> --- (In reply to Tom Rix from comment #3) <snip> > > The big thing I'm seeing is the pre-compiled kernels that are in the -devel > > package (/usr/share/miopen/db). Was that intentional? If so, doesn't that > > violate packaging guidelines? > > can you explain what you mean here ? Aren't the kernels in /usr/share/miopen/db just bunziped from upstream (src/kernels/) or am I reading the build logs incorrectly? > > A few small-ish things: > > - shouldn't URL be https://github.com/ROCm/%{upstreamname} ? > > - shouldn't CMAKE_BUILD_TYPE be RelWithDebInfo? > > - BuildRequires should be pkgconfig instead of explicit XXX-devel > > can you explain what you mean here ? this follows what I been doing for all > the other rocm packages. I think that I've missed the pkgconfig part for reviews that I've done; sorry about that. I even left BuildRequires on *-devel for all the BuildRequires in rocfft which is my bad and I'm going to fix. https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ >From a quick scan through the spec file, it's just some of the BuildRequires, though. bzip2-devel -> pkgconfig(bzip2) eigen3-devel -> pkgconfig(eigen3) libstd-devel -> pkgconfig(libzstd) json-devel -> pkgconfig(nlohmann_json) sqlite-devel -> pkgconfig(sqlite3) zlib-devel -> zlib-ng-devel -> pkgconfig(zlib-ng) # zlib was retired from rawhide and replaced by zlib-ng <snip> > > What is the purpose of compiler/linker patch and math to specify the number > > of compile and link jobs? I tried removing it and it builds without issue, > > is it a speedup? > > it is to prevent thrashing the building when the number of compile and/or > link jobs use too much memory. once we tip over to virtual memory the > machine is effectively crippled and if the build completes it will be days > or weeks later. i have done this for a number of other rocm packages with > similar problems. Ah, OK. My local machine has 64GB so I must have been able to avoid the problem. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2261201 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202261201%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
