https://bugzilla.redhat.com/show_bug.cgi?id=2261201 --- Comment #3 from Tom Rix <trix@xxxxxxxxxx> --- (In reply to Tim Flink from comment #2) > Yay, public domain fun times. As near as I can tell, the text of the license > blerb in src/md5.cpp needs to be filed with other public domain blerbs. > > https://docs.fedoraproject.org/en-US/legal/update-existing-packages/ > #_public_domain > > That being said, I'm a little unclear on if the file is still public domain > since it has been modified from the original but the license header for the > file isn't changed so it probably still is? > > The big thing I'm seeing is the pre-compiled kernels that are in the -devel > package (/usr/share/miopen/db). Was that intentional? If so, doesn't that > violate packaging guidelines? can you explain what you mean here ? > > A few small-ish things: > - shouldn't URL be https://github.com/ROCm/%{upstreamname} ? > - shouldn't CMAKE_BUILD_TYPE be RelWithDebInfo? > - BuildRequires should be pkgconfig instead of explicit XXX-devel can you explain what you mean here ? this follows what I been doing for all the other rocm packages. > - please add notes for what those patches are for and if they're intended > to be long-term vs. temporary > * especially in 0001-prepare-miopen-for-fedora.patch; I think I know what > those bits are for but I'm not sure > > What is the purpose of compiler/linker patch and math to specify the number > of compile and link jobs? I tried removing it and it builds without issue, > is it a speedup? it is to prevent thrashing the building when the number of compile and/or link jobs use too much memory. once we tip over to virtual memory the machine is effectively crippled and if the build completes it will be days or weeks later. i have done this for a number of other rocm packages with similar problems. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2261201 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202261201%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
