https://bugzilla.redhat.com/show_bug.cgi?id=2085444 --- Comment #85 from Daniel Berrangé <berrange@xxxxxxxxxx> --- (In reply to Yunying Sun from comment #84) > For the two choices of separated spec or single linux-sgx.spec for both sdk > & aesm-service, we don't have any preferences. Which option do you recommend? > The aesm-service RPMs build depends on sdk. Will it work with a single > unified linux-sgx.spec to build everything? I'm not sure I have a particularly strong recommendation either way. The default Fedora practice is usually one-upstream tarball / git repo == one downstream source package, though there have been exceptions. If we look at the maint burden going forward, then keeping the bundled 3rd party libraries in sync with desired version is a bit of a pain point, as is responding to any CVEs reproted against openssl. The burden might be reduced in this respect by having a single linux-sgx.spec On the other hand, if I look at the way the build of 'psw' interacts with the 'sdk', the 'psw' buld seems to want the sdk to be fully installed before it will build. I'm not sure how hard it will be to make it build against an uninstalled 'sdk', or an 'sdk' installed in the temporary RPM virtual root directory ? Conceptually it is nice that the 'sdk' doesn't have any pre-compiled binaries too. IOW, I can see arguments in both directions for the spec, but I'd probably tend towards a single specfile, since its the more normal Fedora practice. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2085444 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202085444%23c85 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
