https://bugzilla.redhat.com/show_bug.cgi?id=2085444 --- Comment #84 from Yunying Sun <yunying.sun@xxxxxxxxx> --- (In reply to Daniel Berrangé from comment #83) > Please take a look at my RPM proposal and let me know what you think about > this approach of building from upstream source instead of the current sgxsdk > source tarball. AFAICT, there should be no semantic difference between the > two approaches, except for my decision to use sgxssl and no prebuilt ipp > crypto Your idea and the proposal of building RPMs from upstream source makes perfect sense. It's more clean and straight forward. Thanks a lot for the updated spec, which built fine on koji along with the srpm you shared: https://koji.fedoraproject.org/koji/taskinfo?taskID=108501412 For the two choices of separated spec or single linux-sgx.spec for both sdk & aesm-service, we don't have any preferences. Which option do you recommend? The aesm-service RPMs build depends on sdk. Will it work with a single unified linux-sgx.spec to build everything? Regarding to the sgxssl instead of prebuilt ipp crypto, the missing or renamed libs are needed or not, @xiangquan could you check and comment? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2085444 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202085444%23c84 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
