[Bug 2085444] Review Request: sgx-sdk - Software Guard eXtension software development kit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2085444



--- Comment #86 from xiangquan.liu@xxxxxxxxx ---
(In reply to Daniel Berrangé from comment #83)
> 
> We also don't end up needing any of the pre-built libraries that the sgxsdk
> tarball bundles AFAICT, since we can replace the pre-built crypto with
> sgxssl + openssl.
> 
> Building this way resulted in two extra libraries libtdx_tls.a  and
> libsgx_mbedcrypto.a  that sgxsdk tarball was missing. I don't know if
> they're desirable or not ?

These 2 libraries should be included.

> Also the libsgtcxx.a library is called libsgx_tcxx.a.  sgxsdk seemed to take
> special action to rename it to libsgtcxx.a for some reason. Again I don't
> know if that's desirable or not ?:

libsgtcxx.a is a invalid library here and we can remove it.

> The %{_includedir}/sgxsdk/mbedtls/ files got installed, which was not the
> case with sgxsdk package too.

Right. We need to put mbedtls into include folder.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2085444

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202085444%23c86
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux