https://bugzilla.redhat.com/show_bug.cgi?id=2017179 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zbyszek@xxxxxxxxx | |) | Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #15 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > The author of replxx appears to be no longer responsive, is it possible to apply the patch at https://github.com/AmokHuginnsson/replxx/pull/142 as part of the package build to solve the license issue? I think so. Upstream made a mistake in the licensing annotation, but we have clarified that actual license is more permissive, so we can use the file. No big comments, but some suggestions: > Release: 3%{?dist} 'Release: %autorelease' and '%autochangelog' instead of an explicit changelog, see https://docs.pagure.org/fedora-infra.rpmautospec/opting-in.html > BuildRequires: cmake, gcc, gcc-c++ Please use separate lines for each of the items. > %setup -q > %patch0 -p1 %autosetup -p1 > %cmake . Drop the '.'. https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ don't use it. > ctest -V %{?_smp_mflags} Just '%ctest', see https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/. > %{_libdir}/*.so %{_libdir}/libreplxx*.so The directory %{_datadir}/cmake/%{name} should be owned by the package. So change > %{_datadir}/cmake/%{name}/*.cmake to '%{_datadir}/cmake/%{name}'. > %doc Change that to '%doc README.md'. Hmm, when I download the specified Source0 file, the top directory is called 'replxx-release-0.0.4/'. So it sounds like you need '%autosetup -p1 -n replxx-release-%{version}' %description should be wrapped to <= 80 columns (right now it's ~65). This is pretty close, but let's do another round because of the various small nitpicks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2017179 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202017179%23c15 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
