https://bugzilla.redhat.com/show_bug.cgi?id=2247917 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx CC| |zbyszek@xxxxxxxxx Status|NEW |POST Flags| |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- In %description: > checkout "check out" It's nicer when %description is wrapped to <=80 columns (currently it's rather narrower). 'Release: %autorelease' and '%autochangelog' are recommended instead of an explicit changelog, see https://docs.pagure.org/fedora-infra.rpmautospec/opting-in.html > %{?python_provide:%python_provide python3-%{srcname}} That's not necessary since a long time (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_deprecated_macros). Esp. if %pyproject macros are used, I don't think it makes sense to specify that. + package name is OK + latest version + license is acceptable for Fedora (MIT) + license is specified correctly (in SPDX syntax) + builds and installs OK + python packaging guidelines are followed + P/R/BR look OK (apart from a minor issue noted above) Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2247917 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247917%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
