https://bugzilla.redhat.com/show_bug.cgi?id=2017179 --- Comment #16 from Graham Leggett <minfrin@xxxxxxxx> --- Thank you for this. I have another build at https://copr.fedorainfracloud.org/coprs/minfrin/replxx/build/6600722/ - can you take a look? >> Release: 3%{?dist} >'Release: %autorelease' and '%autochangelog' instead of an explicit changelog, see https://docs.pagure.org/fedora-infra.rpmautospec/opting-in.html I wasn't able to get this to work, working from a simple rpmbuild/SPECS file directory right now, I believe %autorelease needs git? >> BuildRequires: cmake, gcc, gcc-c++ >Please use separate lines for each of the items. Done. >> %setup -q >> %patch0 -p1 >%autosetup -p1 Done. >> %cmake . >Drop the '.'. https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ >don't use it. Done. >> ctest -V %{?_smp_mflags} >Just '%ctest', see https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/. Done. >> %{_libdir}/*.so >%{_libdir}/libreplxx*.so Done. >The directory %{_datadir}/cmake/%{name} should be owned by the package. >So change >> %{_datadir}/cmake/%{name}/*.cmake >to '%{_datadir}/cmake/%{name}'. Done. >> %doc >Change that to '%doc README.md'. Done. > Hmm, when I download the specified Source0 file, the top directory is called 'replxx-release-0.0.4/'. > So it sounds like you need '%autosetup -p1 -n replxx-release-%{version}' Done. > %description should be wrapped to <= 80 columns (right now it's ~65). Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2017179 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202017179%23c16 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
