https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- The packaging itself looks fine, but looking at the sources themselves, they are *a mess*: - The "runtime/themes/*" contents are covered under different licenses - are they copied from different projects? - The "runtime/grammars/*" contents appear to be bundled copies of tree-sitter-* crates and / or other tree-sitter subprojects, and they are covered under different licenses. Notably, the "hcl" grammar contains lots of example / data files that are covered under various licenses. I don't think they are included in the final package, but that needs to be verified. Especially bundling all the tree-sitter stuff (including some tree-sitter sources / headers themselves) looks very suspicious to me. Shouldn't they be part of the tree-sitter package? Or do they work in a way where every package that uses tree-sitter grammars installs their own .so files? If this is the case, I think this package would at least need to specify that the tree-sitter grammars are indeed bundled (i.e. add something like "Provides: bundled(tree-sitter-astro) = 0.0.1" for every bundled grammar, and "Provides: bundled(tree-sitter) = x.y.z" for whatever version of tree-sitter that the sources are taken from). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
