https://bugzilla.redhat.com/show_bug.cgi?id=2247020 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some small drive-by comments (I hope you don't mind!): - "rust-packaging >= 23" is obsolete, it should be "cargo-rpm-macros >= 24" now. It's also the new default with rust2rpm v25, which has been out for ~2 weeks. - Looks like you're missing the systemd scriptlets for the service: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd - Making directory ownership explicit in %files is almost always better than having it implicit, for example %{_datadir}/speakersafetyd %{_sharedstatedir}/speakersafetyd would become %{_datadir}/speakersafetyd/ %{_sharedstatedir}/speakersafetyd/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2247020 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247020%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
