https://bugzilla.redhat.com/show_bug.cgi?id=2246872 --- Comment #3 from e.ohlms@xxxxxxxxxxxxxxxxxx <e.ohlms@xxxxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #1) > Initial comments: > a) Can you reference the source: > https://github.com/Setup-Tooling/Setup-Tool-for-Fedora > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_git_tags > b) Probably do not want to hard code versions in: > https://github.com/Setup-Tooling/Setup-Tool-for-Fedora/blob/stable/cli/setup- > tool-cli.c > c) use desktop-file-install > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files > d) Add compiler flags: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags > e) The tool may hide that one is installing packages from outside the main > Fedora repositories. > This may be undesirable. > f) Replace > %license %{_datadir}/licenses/setup-tool/LICENSE > %doc %{_datadir}/doc/setup-tool/README.md > with > %license LICENSE > %doc README.md > They will be put in the correct locations > g) Use > cp -p > or > install -p -D755 > or > install -p -D644 > to preserve timestamps. The install command allows setting of permissions. > h) Use SPDX license identifier either MPL-2.0 > https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ I have done all of that and now get this build error: (command run) rpmbuild -ba /home/burningpho3nix/rpmbuild/SPECS/Normal/setup-tool-starter.spec setting SOURCE_DATE_EPOCH=1698624000 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.4FsOtt + umask 022 + cd /home/burningpho3nix/rpmbuild/BUILD + cd /home/burningpho3nix/rpmbuild/BUILD + rm -rf setup-tool-1.4.103c + /usr/lib/rpm/rpmuncompress -x /home/burningpho3nix/rpmbuild/SOURCES/1.4.103c.tar.gz error: File /home/burningpho3nix/rpmbuild/SOURCES/1.4.103c.tar.gz: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.4FsOtt (%prep) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.4FsOtt (%prep) The hard coded Fedora versions where, because otherwise it tried to download version: 000000. I actively rewrite those code snippets when Fedora versions are removed from the list of versions supported by the program. The use of the names "Fedora", "RHEL" and "CentOS Stream" on Github is so that people can see the OS that the version of the program is for. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2246872 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246872%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
