https://bugzilla.redhat.com/show_bug.cgi?id=2238751 --- Comment #14 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > I couldn't easily find any rust package using that btw. fixed There's over 2000 Rust packages, and they are only being transitioned from BR: rust-packaging to BR: cargo-rpm-macros over time. > Well, I named it after the lib and .pc, I think it's more straightforward this way. Makes sense to me. Thanks! === I'd approve the package, but it doesn't build anymore: > error: no matching package named `once_cell` found > location searched: registry `crates-io` You need to run `%cargo_generate_buildrequires` inside the "ffi" directory, as far as I can tell, i.e. """ %generate_buildrequires cd ffi %cargo_generate_buildrequires cd .. """ It is *very* unusual to have the "workspace root" in a subpackage of the actual "project root" ... but that's an upstream problem. === And there's a warning because you now patch to set both package.license *and* package.license-file: > warning: /builddir/build/BUILD/rutabaga-gfx-20230913/Cargo.toml: only one of `license` or `license-file` is necessary > `license` should be used if the package license can be expressed with a standard SPDX expression. > `license-file` should be used if the package uses a non-standard license. > See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2238751 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238751%23c14 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
