[Bug 2238751] Review Request: rutabaga-gfx-ffi - Handling virtio-gpu protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2238751



--- Comment #13 from Marc-Andre Lureau <marcandre.lureau@xxxxxxxxxx> ---
(In reply to Fabio Valentini from comment #12)
> > > 10. Please bump the BuildRequires from "rust-packaging >= 21" to
> > > "cargo-rpm-macros".
> > > The "rust-packaging" package no longer exists and is only provided by
> > > "cargo-rpm-macros" for backwards compatibility.
> > 
> > ok
> 
> I don't know what happened here, the new line is
> 
> BuildRequires:  rust-srpm-macros >= 24
> 
> - which is wrong. The rust-srpm-macros package is included in the default
> buildroot, and does not contain the cargo RPM macros.
> When I said to replace the "rust-packaging >= 21" BR with just
> "cargo-rpm-macros", I meant what I said 😅

oh ok.. I screwed up. I couldn't easily find any rust package using that btw.
fixed

> 
> Other than that, thank you for the update, looks good.
> Not sure if rutabaga-gfx-ffi or rutabaga-gfx would be the better package
> name (since the -ffi suffix is meaningless here) though, but that's your
> decision.

Well, I named it after the lib and .pc, I think it's more straightforward this
way.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2238751

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238751%23c13
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux