[Bug 2238751] Review Request: rutabaga-gfx-ffi - Handling virtio-gpu protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2238751



--- Comment #15 from Marc-Andre Lureau <marcandre.lureau@xxxxxxxxxx> ---
(In reply to Fabio Valentini from comment #14)
> > error: no matching package named `once_cell` found
> > location searched: registry `crates-io`
> 
> You need to run `%cargo_generate_buildrequires` inside the "ffi" directory,
> as far as I can tell, i.e.
> 
> """
> %generate_buildrequires
> cd ffi
> %cargo_generate_buildrequires
> cd ..
> """

ok

> 
> It is *very* unusual to have the "workspace root" in a subpackage of the
> actual "project root" ... but that's an upstream problem.


We could eventually package the rust-rutabaga-gfx first, modify the -ffi and
compile against it. Is that really preferable?

> 
> ===
> 
> And there's a warning because you now patch to set both package.license
> *and* package.license-file:
> 
> > warning: /builddir/build/BUILD/rutabaga-gfx-20230913/Cargo.toml: only one of `license` or `license-file` is necessary
> > `license` should be used if the package license can be expressed with a standard SPDX expression.
> > `license-file` should be used if the package uses a non-standard license.
> > See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information.

hmm, I'll drop license-file in the patch then.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2238751

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238751%23c15
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux