https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #5 from Link Dupont <link@xxxxxxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #4) > For "%global godocs" and "%doc"s in the %files section you can have > something in between of a long line and a line per file. COL80 is best > practice. I took a middle-ground approach and combined the package docs into a couple of lines, limited by 80 characters. For the sources and databases, I opted for one-per-line; hopefully this makes adding new sources and databases later a little easier. > > export BUILDTAGS="%{_gobuildtags}" > > %gobuild -o %{gobuilddir}/bin/migrate %{goipath}/cmd/migrate > > Have you checked this? I'm fine if you don't use this way, just wanted to > make sure you've checked it. I did. I think it really comes down to a matter of style. I suppose there is the possibility that exporting the variable would be a better way of ensuring it gets included in the %gobuild execution line, but I can't think of a situation where that nuance would matter. > > Name: %{goname} > > What about chanching the name of the package to "migrate"? > > You can generate it with "go2rpm --name migrate > github.com/golang-migrate/migrate". It will add a new %global entry, you can > check examples like `doctl` or `gh`. Good idea. I regenerated the package with go2rpm and saw that it just adds `%global goname migrate` after %gometa, so I added that change. > > %global common_description %{expand: > > Go database migrations library and program.} > > It would be great, but not requried, if you could add in the description > which supported DBs are included with the Fedora build. Something like: > > %global common_description %{expand: > Go database migrations library and program. > > Supports: > * file > * iofs > * sqlite3 > * postgres > } Good idea. I modified the description. Spec URL: https://linkdupont.fedorapeople.org/reviews/golang-github-migrate.spec SRPM URL: https://linkdupont.fedorapeople.org/reviews/golang-github-migrate-4.16.2-1.fc39.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
