https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #4 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > but have had to duplicate the list of docs; once in %godocs and again in %files. Yes, you've to duplicate the list. For "%global godocs" and "%doc"s in the %files section you can have something in between of a long line and a line per file. COL80 is best practice. >> for cmd in cmd/* ; do >> BUILDTAGS="%{_gobuildtags}" %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd >> done > > It may be just a style thing, but I would split the line in a export and the build command: > > export BUILDTAGS="%{_gobuildtags}" > %gobuild -o %{gobuilddir}/bin/migrate %{goipath}/cmd/migrate Have you checked this? I'm fine if you don't use this way, just wanted to make sure you've checked it. > Name: %{goname} What about chanching the name of the package to "migrate"? You can generate it with "go2rpm --name migrate github.com/golang-migrate/migrate". It will add a new %global entry, you can check examples like `doctl` or `gh`. > %global common_description %{expand: > Go database migrations library and program.} It would be great, but not requried, if you could add in the description which supported DBs are included with the Fedora build. Something like: %global common_description %{expand: Go database migrations library and program. Supports: * file * iofs * sqlite3 * postgres } -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
