[Bug 2218606] Review Request: golang-github-migrate - Go database migrations library and program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2218606

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mikel@xxxxxxxxxxxxxxx
             Status|NEW                         |ASSIGNED



--- Comment #6 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
> I took a middle-ground approach and combined the package docs into a couple of lines, limited by 80 characters. For the sources and databases, I opted for one-per-line; hopefully this makes adding new sources and databases later a little easier.

Makes sense.

> I did. I think it really comes down to a matter of style.

Fine.

> Good idea. I regenerated the package with go2rpm and saw that it just adds `%global goname migrate` after %gometa, so I added that change.

I forgot to mention you need to edit this BZ ticket's title to match the new
name.

> Good idea. I modified the description.

I like how you did.

Change the title and I'll approve the package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2218606

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c6
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux