https://bugzilla.redhat.com/show_bug.cgi?id=2182151 Steve Dickson <steved@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ppisar@xxxxxxxxxx | |) --- Comment #45 from Steve Dickson <steved@xxxxxxxxxx> --- (In reply to Petr Pisar from comment #44) > Source0 URL is Ok. > Source archive (SHA-512: > cee06b1f50574fb338be29dd39befe460fc7d80c3b1097954fc172bb3c28e855428845f16f161 > 506763d81ae397e977e897d81c42f059870c2d858b9623c77e3) is original. Ok. > > New licenses found: > aclocal.m4: FSFULLRWD AND GPL-2.0-or-later WITH Autoconf-exception-generic > AND FSFULLR > compile: GPL-2.0-or-later WITH Autoconf-exception-generic > configure: FSFULLR > install-sh: X11 > Makefile.in, src/Makefile.in, src/tlshd/Makefile.in, systemd/Makefile.in: > FSFULLRWD AND GPL-2.0-only > missing: GPL-2.0-or-later WITH Autoconf-exception-generic > > Changed licenses: > README, README.md: GPL-1.0-or-later → GPL-2.0-only > > Removed licenses: > THIRD_PARTY_LICENSES: LGPL-2.1 text > > FIX: Remove "AND GPL-1.0-or-later" from a License tag because README.md > changed the license. > > TODO: Remove "%autopatch -p1". from %prep section. There are no patches. Unless this is perfect code... There will be patches... :-) > > $ rpmlint ktls-utils.spec ../SRPMS/ktls-utils-0.9-1.fc39.src.rpm > rpmlint is Ok. > > > FIX: The package fails to build on i686 in F39 > (https://koji.fedoraproject.org/koji/taskinfo?taskID=101969239) with the > same error. Either fix it, or exclude building from 32-bit x86 architectures. This is a process error!!! Traceback (most recent call last): File "/usr/lib/python3.11/site-packages/mockbuild/trace_decorator.py", line 93, in trace result = func(*args, **kw) ^^^^^^^^^^^^^^^^^ Has nothing to do with the actual package!!! There is no python in the package so how can python cause a build to fail??? > > Please correct the FIX items, consider fixing TODO items, and provide an > updates spec file. Please reconsider approving this package... It should not be this difficult to get a truly need package approved... IMHO -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2182151 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202182151%23c45 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
