https://bugzilla.redhat.com/show_bug.cgi?id=2182151 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ppisar@xxxxxxxxxx | |) | --- Comment #46 from Petr Pisar <ppisar@xxxxxxxxxx> --- Steve, I cannot approve a package which breaks the packaging guidelines. One of the requirement is that the package builds in Koji for Rawhide. And that this package does not meet. The python trace is just sloppy way to express that the rpmbuild invocation failed. Scanning build.log before that reveals this error: make[3]: Entering directory '/builddir/build/BUILD/ktls-utils-0.9/src/tlshd' gcc -DHAVE_CONFIG_H -I. -I../.. -Werror -Wall -Wextra -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -pthread -I/usr/include/libnl3 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -c -o tlshd-config.o `test -f 'config.c' || echo './'`config.c make[3]: Leaving directory '/builddir/build/BUILD/ktls-utils-0.9/src/tlshd' config.c: In function 'tlshd_config_read_datum': config.c:155:52: error: comparison of integer expressions of different signedness: '__off_t' {aka 'long int'} and 'unsigned int' [-Werror=sign-compare] 155 | if (statbuf.st_size < 0 || statbuf.st_size > UINT_MAX) { | ^ cc1: all warnings being treated as errors make[3]: *** [Makefile:478: tlshd-config.o] Error 1 Another item is that the license tag is accurate. Listing a license which is not in the code violates it. I'm really sorry, but it's the packager's due to address these items. I are blaming a wrong person. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2182151 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202182151%23c46 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
