[Bug 2209759] Review Request: rocclr - ROCm Compute Language Runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2209759

Tom Stellard <tstellar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(tstellar@redhat.c |
                   |om)                         |



--- Comment #12 from Tom Stellard <tstellar@xxxxxxxxxx> ---
(In reply to Jeremy Newton from comment #11)
> > Which blender are you using, can you send me instructions ?
> 
> I just used Fedora's Blender package. Go to edit->preferences to open the
> preferences window, then click on "System" on the left then "HIP" on the top.
> If you install rocm-hip, check on a system with supported HW, it will be
> found in the list. If you then delete the libamdhip64.so symlink, it won't
> find hip anymore.
> I'll fix the package for now and we can fix blender later.
> 
> > Using fedora's with -DWITH_CYCLES_HIP_BINARIES=ON fails in to build in a non hip area.
> 
> I'm not sure about this, I just used the existing fedora package. I guess
> maybe you can build blender against hip-devel or rocm-hip-devel to get it to
> link at compile time?
> 
> > Note: Incorrect Requires : /usr/lib64/amdgcn/bitcode
> 
> I can use just "Requires: rocm-device-libs" if that works for you, but
> rpmlint complains about explicit-lib-dependency. I guess I can just ignore
> it.
> 
> > could bitcode/ be installed into clang's resource dir ?
> 
> Sure I can do that, but it's unrelated to the dependency. Basically the
> default is to install to /usr/amdgcn/bitcode, so I patched it to put it in
> /usr/lib64/amdgcn/bitcode (arbitrary decision). Putting it in
> /usr/lib64/clang/VERSION/amdgcn/bitcode or similiar is fine by me, but I'll
> need to land multiple patches in the existing packages to stage it over to
> the new location.
> Is this blocking for this review? Or can I do it later? I'll start the work
> on moving it now if you think it's valuable; I just don't understand the
> logic on the clang side and would need to dive into that code a bit to find
> the best location for the bitcodes.

Where does clang search for this by default?  I think it would make sense to
put the bit code in that directory.  I know this code in clang fairly well and
I can help debug it if you give me a simple example.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2209759
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux