https://bugzilla.redhat.com/show_bug.cgi?id=2209759 --- Comment #15 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- > Also rocm-opencl should probably require rocm-device-libs anyway. How come? I don't see any code paths in OpenCL requiring it at all. Hip needs it because of hipcc as far as I know and rocm-device-libs is used generally during compilation. In other words, rocm-device-libs is not a runtime dependency, only build time. > Where does clang search for this by default? I was actually trying to figure that out, as I'm a bit unfamiliar with the code. I see this: https://github.com/llvm/llvm-project/blob/release/16.x/clang/lib/Driver/ToolChains/HIPAMD.cpp#L346 and https://github.com/llvm/llvm-project/blob/release/16.x/clang/lib/Driver/ToolChains/HIPSPV.cpp#L215 The whole thing looks a bit opaque to me, so feel free to help out :) > 1. rocm-device-libs > follow what libomp does and use > Requires: clang-resource-filesystem%{?isa} = %{version} > to install amdgcn/bitcode into clang's resource dir lib/ Sure I'm ok with this if Tom Stellar is willing to help out with the LLVM patching side. Or I can also reach out to rocm device libs upstream to see if they can guide me towards making a patch that they're ok with. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2209759 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
