https://bugzilla.redhat.com/show_bug.cgi?id=2209759 Tom Rix <trix@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(trix@xxxxxxxxxx) | --- Comment #10 from Tom Rix <trix@xxxxxxxxxx> --- Which blender are you using, can you send me instructions ? Using fedora's with -DWITH_CYCLES_HIP_BINARIES=ON fails in to build in a non hip area. The rocm-device-libs, imo needs to be solved in where the bitcode/ is install and/or get clang to look. I did not take a close look yet at this yet to see which was the better approach. My notes from the spec file --- a/rocclr.spec +++ b/rocclr.spec @@ -46,6 +46,8 @@ BuildRequires: pkgconfig(numa) BuildRequires: pkgconfig(ocl-icd) BuildRequires: python3-cppheaderparser BuildRequires: rocm-comgr-devel +# it would be good if these rocm packages were versioned so +# we are not mixing 5.5.0 and 5.5.1 BuildRequires: rocminfo BuildRequires: rocm-runtime-devel BuildRequires: zlib-devel @@ -106,6 +108,11 @@ ROCm HIP development package. %package -n hip Summary: C++ Runtime API and Kernel Language BuildArch: noarch +# [!]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. +# Note: Incorrect Requires : /usr/lib64/amdgcn/bitcode +# See: https://docs.fedoraproject.org/en-US/packaging- +# guidelines/#_file_and_directory_dependencies +# could bitcode/ be installed into clang's resource dir ? # hipcc requirements: Requires: %{_libdir}/amdgcn/bitcode Requires: rocminfo @@ -273,6 +280,13 @@ fi %{_libdir}/libamdhip64.so.5{,.*} %{_libdir}/libhiprtc.so.5{,.*} %{_libdir}/libhiprtc-builtins.so.5{,.*} +# +# rocm-hip.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libamdhip64.so +# I do not like this work around, applications need to follow libraries +# even if that means rebuilding the application. Since blender should be +# using this library and not the AMD version. This likely mean cleaning/enhancing +# up other applications as ROCm is generally available on fedora. + # Workaround blender issue: blender looks for libamdhip64.so instead of the # versioned counterpart, so include the .so symlink in the runtime package %{_libdir}/libamdhip64.so -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2209759 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
