[Bug 2209759] Review Request: rocclr - ROCm Compute Language Runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2209759

Jeremy Newton <alexjnewt@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(trix@xxxxxxxxxx)



--- Comment #9 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> ---
OK sorry, one more update:
Spec URL: https://mystro256.fedorapeople.org/rocclr.spec
SRPM URL: https://mystro256.fedorapeople.org/rocclr-5.5.1-4.fc39.src.rpm
copr build:
https://copr.fedorainfracloud.org/coprs/mystro256/rocm-hip/build/5989231/

I added a new "hip" package as it turns out hipcc and hipconfig are used at
runtime, such as with Blender.
Now doing "sudo dnf install rocm-hip" will allow for running blender without
any issue on my system.
The only caveat is that blender checks for "libamdhip64.so" instead of
"libamdhip64.so.5" or similar, so I moved the libamdhip64.so symlink to the
rocm-hip package to workaround this issue. This introduces a
devel-file-in-non-devel-package rpmlint warning.

Excluding that, I got the rpmlint out down to just a few
no-manual-page-for-binary and no-documentation warnings, which I think can be
ignored.

As well, I used the following to add a requires on rocm-device-libs for hipcc
but I did it in a way to silence a rpmlint explicit-lib-dependency warning:

> # hipcc requirements:
> Requires:       %{_libdir}/amdgcn/bitcode

It seems ok to me since hipcc now looks for this directory due to the sed
patchwork in %prep, but I can change it back to "rocm-device-libs" if you don't
like adding directory requires like this.

@trix, what do you think?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2209759
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux