[Bug 2188762] Review Request: golang-github-containerd-cgroups-3 - Cgroups package for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2188762

Sergio Basto <sergio@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(sergio@xxxxxxxxxx |
                   |)                           |



--- Comment #5 from Sergio Basto <sergio@xxxxxxxxxx> ---

- I removed the Epoch

- enabled teste and removed "TestCgroupv2CpuStats"
"TestSystemdCgroupCpuController" "TestSystemdCgroupCpuController_NilWeight"
"TestEventChanCleanupOnCgroupRemoval"\
"TestCgroupv2MemoryStats" "TestSystemdCgroupMemoryController"
"TestCgroupv2PidsStats" "TestSystemdCgroupPidsController" "TestKill" because
needs special permissions 

- Fixed the File listed twice like was in golang-github-cloudflare-circl.spec


about goipathsex0 in golang channel me and gotmax23 talk: 

sergiomb: the problem of golang-github-containerd-cgroups-3 is have cmd/go.mod 
cmd/go.sum  which aren't meant to bulld
  mkdir v3
  mv cmd/go.mod cmd/go.sum v3
  seems thats fixes the problem 
gotmax23G :That won't work either
sergiomb: can you explain ? where it will fail
gotmax23: The cmd directory needs to be outside of the v3 directory.

(later)

gotmax23: Hmm, it might be possible to regenerate a clean specfile with go2rpm
--forge https://github.com/containerd/cgroups github.com/containerd/cgroups/v3
and then add %global goipathsex0 github.com/containerd/cgroups/v3/cmd right
under %gometa.

(later) 

sergiomb: after %gometa %global goipathsex0
github.com/containerd/cgroups/v3/cmd  makes disappear cmd at all
gotmax23: That's the point. Since no other package should depend on the cmd
module, it might be best to just exclude it rather than install it at the wrong
location.


new spec and src.rpm uploaded


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2188762
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux