https://bugzilla.redhat.com/show_bug.cgi?id=2188762 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(sergio@xxxxxxxxxx | |) --- Comment #4 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- >> Why epoch is needed for this new package? > because golang-github-containerd-cgroups also have epoch = 1 and golang-github-containerd-cgroups-3 need be bigger than golang-github-containerd-cgroups In the case of `golang-github-containerd-cgroups` it is required because a newer version was pushed and then restored the old one. For `golang-github-containerd-cgroups-3`, the package name is different (has the -3) and goipath is also different. I don't see it as required. > %global goipathsex0 github.com/containerd/cgroups/v3/cmd Why is this one required? Builds fine for me without it. > # Needs special permissions for cgroupsv2 > %bcond_with check Skip those tests failing, not all the tests. You can check how `doctl.spec` does for example to skip just some tests. > RPM build warnings: > File listed twice: /usr/share/doc/golang-github-containerd-cgroups-3/metrics.pb.txt > File listed twice: /usr/share/doc/golang-github-containerd-cgroups-3-devel/metrics.pb.txt You can check how to fix this one using `golang-github-cloudflare-circl.spec` LICENSE rename as example. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188762 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
