https://bugzilla.redhat.com/show_bug.cgi?id=2188762 Sergio Basto <sergio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sergio@xxxxxxxxxx | |) | --- Comment #3 from Sergio Basto <sergio@xxxxxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #2) > > Epoch: 1 > > Why epoch is needed for this new package? > because golang-github-containerd-cgroups also have epoch = 1 and golang-github-containerd-cgroups-3 need be bigger than golang-github-containerd-cgroups > > Release: 3%{?dist} > > Why it doesn't start from 1? > > But also, why are you not using %autorelease? > fixed > > %build > > mkdir v3 > > mv cmd/go.mod cmd/go.sum v3 > > for cmd in cmd/* ; do > > %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd > > done > (...) > > install -m 0755 -vd %{buildroot}%{_bindir} > > install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ > > Is the cmd useful? if we can build it and provides the binary /usr/bin/cgctl , why not ? golang-github-containerd-cgroups doesn't provides it, but we need a trick to build it, we need to move cmd/go.mod cmd/go.sum away from the directory cmd [1] [1] mkdir v3 mv cmd/go.mod cmd/go.sum v3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188762 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
