https://bugzilla.redhat.com/show_bug.cgi?id=2188762 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Flags| |fedora-review? | |needinfo?(sergio@xxxxxxxxxx | |) Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #6 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- I have my own SPEC going on in #2229425. Anyhow - Bump to 3.0.2 - Are these files needed? For what purpose are they in docs? cgroup2-stats-metrics.pb.txt cgroup1-stats-metrics.pb.txt - What is the purpose of: mkdir v3 mv cmd/go.mod cmd/go.sum v3 Just do: %build %gobuild -o %{gobuilddir}/bin/cgctl %{goipath}/cmd/cgctl - Format this: for test in "TestCgroupv2CpuStats" \ "TestSystemdCgroupCpuController" \ "TestSystemdCgroupCpuController_NilWeight" \ "TestEventChanCleanupOnCgroupRemoval" \ "TestCgroupv2MemoryStats" \ "TestSystemdCgroupMemoryController" \ "TestCgroupv2PidsStats" \ "TestSystemdCgroupPidsController" \ "TestKill" \ "TestMoveTo" ; do awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test) done - Don't glob the binary directory: %files %license LICENSE %doc README.md %{_bindir}/cgctl - > sergiomb: the problem of golang-github-containerd-cgroups-3 is have cmd/go.mod cmd/go.sum which aren't meant to bulld This is really not needed, Fedora Go macros don't use Go modules. You can remove it. Please update the SPEC and we'll get back to it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188762 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202188762%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
