https://bugzilla.redhat.com/show_bug.cgi?id=2166379 --- Comment #9 from Jan Staněk <jstanek@xxxxxxxxxx> --- (In reply to Tom Stellard from comment #7) > The spec file looks OK to me. The only part I'm not sure about is > completely overriding the build_cflags. Normally, I would object to this, > but I don't know which of the flags in build_cflags are supported or even > relevant for wasm. Have you checked to see which flags the upstream uses ? In upstream, the CFLAGS originally contain `-O2 -DNDEBUG`, and then a bunch of other flags are appended: > CFLAGS += --target=$(TARGET_TRIPLE) > CFLAGS += -fno-trapping-math > CFLAGS += -Wall -Wextra -Werror \ > -Wno-null-pointer-arithmetic \ > -Wno-unused-parameter \ > -Wno-sign-compare \ > -Wno-unused-variable \ > -Wno-unused-function \ > -Wno-ignored-attributes \ > -Wno-missing-braces \ > -Wno-ignored-pragmas \ > -Wno-unused-but-set-variable \ > -Wno-unknown-warning-option ... and also flags specific for threading model, etc. Originally, I tried to just patch/adjust the build_cflags as set by distribution, but that throws off testing – during build, the compiler emits definitions and values of a list of macros (`#define __SIZE_MAX__ 4294967295UL` and similar) and these are checked against expected values. Using the distribution flags, the expected files had to be patched. Some of the values I know to be pretty much just informational, however, most of them are not familiar to me, so I prefer not to touch them unless necessary. In other words, I'm not against just adjusting/specifying different %build_cflags, but someone has to tell me what the correct value is :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166379 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
